Skip to main content

Engineering on Legacy Code

A recent project I was on meant testing a lot of legacy code,  in fact I think it was all legacy code! So I thought I'd write some bits about what the challenges are or what you should look for.

Firstly, let me start by defining what I mean by legacy code. I have seen definitions of legacy code which state any code without unit tests can be defined as legacy, whilst this is true, I also like to think of legacy code as something that isn't being refactoring, isn't being improved upon, it is what it is, to quote Ronseal "it does exactly what it says on the tin".

The problem with the Ronseal analogy, is that what happens if you can't find the tin? Or you can't make sense of the tin? This brings me onto the first challenge... In that if it is legacy code, and there's no supporting documentation around how it works or what certain features are for, then it makes our lives as testers (and developers) difficult. We have to ask questions over what certain things do, and more often than not the person we ask won't know either. This tripped me up in the projects first release, and I'm not too ashamed to admit, but we had to rollback the release due to a bug about us not truly understanding some legacy feature. This was a good lesson, we learnt from it, and we were far more cautious and inquisitive about future releases. We made sure we understood everything.

Which brings me onto the next challenge/tip. Make sure you understand everything around the legacy code that you are testing, if there's documentation, read it, if there's questions that need answering then ask them. There is no such thing as a stupid question! This will all help drive your testing and helping you decide what and how to test.

Another challenge around how to test legacy code, is that you are often limited by what has been developed in the past, for instance we wanted to perform performance testing on an internal application, but we had no scripts for this, performance testing of this application wasn't ever considered necessary, until now. The problem is that we needed performance testing, as we were increasing the amount of data for certain calls. We didn't have time for anyone to develop performance tests, so we had to decide to perform the testing at a lower level, by testing the sprocs that retrieved and set the data, this gave us enough confidence, and was relatively quick and easy to do.

Finally, with there being no unit tests on the code, and no automated tests that worked, we were forced to do more manual testing than I perhaps would have liked.

Despite the above challenges, we successfully released the project on time. A lot of this was down to how we managed the releases and released small pieces in quick succession, for instance had we released big bang and found the bug that caused the first release to be rolled back, we would have had to rollback everything which would not have been fun!


So there you have it, a few challenges that I came across when testing on a legacy system. What challenges can you think of? This post started with the title "Testing on legacy code", but I think if you replace the word testing with developing for this post, a lot of the points will still hold true,  it's not just about testing but engineering on legacy code. I know you can make the case that the above is everything you should be trying to achieve when testing any code, but I think when testing on  the legacy code, the above points are even more important.

Comments

Popular posts from this blog

Testers: Be more like a Super-Villain!

Who doesn't love a Super Hero? Talk to my son, and he'll tell you how much he loves them, talk to many adults and they'll say the same! Deep down, we all love to be the Super Hero, we all want to save the day! However, I want to talk about the flip side of Super Heroes, the Super Villains... I often play Imaginext with my son, and I (unfortunately?) am nearly always the Super Villain! Be it Lex Luthor, Joker, Two Face, Mr Freeze or The Riddler! These are all great characters and great Super Villains, but why would I want to write about Super Villains? A while ago where I worked, we had a few Super Heroes, people who would be able to come in and "fix" things that had broken and help deliver projects on time. We then shifted, we decided to do away with the Super Hero culture and try and prevent from being in that position in the first place, whilst we didn't go as far as wanting to hire Super Villains, it's definitely a story that has stuck with me and t...

QA is Awesome!

No real point to this post other than I have had the song stuck in my head and figured I could change it slightly and quite easily make QA is Awesome! Oh and I haven't even seen the movie all the way through! But for some reason that song is incredibly catchy! Not much point to this post in fact, just thought I'd put it out there :)

Measuring QA Key Skills and Competencies

I have been thinking about how I can help encourage self improvement within my team, as I understand it, everyone wants to improve, it's just that often there are a number of things that hold people back. I believe one of these things that hold people back are around identifying skills that they are perhaps weak in or that they could/should improve on. So I thought about how I can help tackle that problem. One solution that I want to try with people is to identify the key skills for a QA, what key skills should every QA have, or at least what key skills make up a good QA? If I can identify these then I can start helping people identify if they are lacking in an area. Sure there is a competency matrix that we have, but it has things like "An excellent understanding of XXX", it's often very difficult to quantify what an excellent understanding actually is. So I sat down and came up with the following key skills: OOP Test Documentation Manual Testing Automated...